call t.Error() from sub-tests not Scenario.Run() #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch addresses a couple related problems, all with the evaluation of testing.T failures. When `testing.T.Run()` is executed, a new goroutine is spawned with a new `testing.T` pointer. This specific goroutine's `testing.T` pointer needs to have *its* `testing.T.Error()` method called in order for that sub-test to be marked failed. We were erroneously calling `testing.T.Error()` within the `Scenario.Run()` method instead of inside the `Spec.Eval()` method, which resulted in the test scenario being marked failed instead of the individual test unit. We address the exec plugin's `Spec.Eval()` in this patch to call `testing.T.Error()` on any assertion failure however additional patches are coming for the http and kube plugins. Finally, I made a change to the `gdterrors.TimeoutExceeded()` function to allow for an assertion failure message to be supplied to the error producer, making it easier for folks to see "this test assertion failed to succeed before a timeout of (duration)". Addresses Issue #8 Signed-off-by: Jay Pipes <jaypipes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses a couple related problems, all with the evaluation of testing.T failures. When
testing.T.Run()is executed, a new goroutine is spawned with a newtesting.Tpointer. This specific goroutine'stesting.Tpointer needs to have itstesting.T.Error()method called in order for that sub-test to be marked failed. We were erroneously callingtesting.T.Error()within theScenario.Run()method instead of inside theSpec.Eval()method, which resulted in the test scenario being marked failed instead of the individual test unit.We address the exec plugin's
Spec.Eval()in this patch to calltesting.T.Error()on any assertion failure however additional patches are coming for the http and kube plugins.Finally, I made a change to the
gdterrors.TimeoutExceeded()function to allow for an assertion failure message to be supplied to the error producer, making it easier for folks to see "this test assertion failed to succeed before a timeout of (duration)".Addresses Issue #8