ensure no retry for create/apply/delete #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only want to retry kube.get actions, not create, apply or delete. In bringing in gdt@v1.9.0, we now have override ability for an individual Evaluable's Retry and Timeout. When adding this functionality, it became evident that KinD clusters don't immediately add the default service account, which is required for simple tests like the creation of an nginx Pod. So, added a wait loop inside the KindFixture's Start method that waits for up to 15 seconds until it sees the existence of the default service account. Issue gdt-dev#17 Signed-off-by: Jay Pipes <jaypipes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want to retry kube.get actions, not create, apply or delete. In bringing in gdt@v1.9.0, we now have override ability for an individual Evaluable's Retry and Timeout.
When adding this functionality, it became evident that KinD clusters don't immediately add the default service account, which is required for simple tests like the creation of an nginx Pod.
So, added a wait loop inside the KindFixture's Start method that waits for up to 15 seconds until it sees the existence of the default service account.
Issue #17