fix: call t.Error() from test spec #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings in gdt@v1.1.1 and ensures that the test units/specs call `testing.T.Error()` instead of relying on the `Scenario.Run()` to do that. Also adds a custom YAML unmarshaler for the `Expect` struct and adds better parse-time errors for the `matches` field as requested in Issue 8. Addresses Issue gdt-dev/gdt#8 Signed-off-by: Jay Pipes <jaypipes@gmail.com>
jaypipes
commented
Aug 8, 2023
| } | ||
| e.Matches = v | ||
| } else if valNode.Kind == yaml.ScalarNode { | ||
| if valNode.Tag == "!!null" { |
There was a problem hiding this comment.
note to @a-hilaly this is actually the only way to tell that someone put the following in their YAML:
some:
nested:
mapfield:where some.nested.mapfield has a nil value (it's actually valid YAML...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in gdt@v1.1.1 and ensures that the test units/specs call
testing.T.Error()instead of relying on theScenario.Run()to do that.Also adds a custom YAML unmarshaler for the
Expectstruct and adds better parse-time errors for thematchesfield as requested in Issue 8.Addresses Issue gdt-dev/gdt#8