Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dissasm fix some bugs with comments and added automatic unit testing job #259

Merged
merged 20 commits into from
Mar 10, 2024

Conversation

rzaharia
Copy link
Collaborator

@rzaharia rzaharia commented Mar 8, 2024

No description provided.

@rzaharia rzaharia added Bug Something isn't working Enhancement New feature or request labels Mar 8, 2024
@rzaharia rzaharia self-assigned this Mar 8, 2024
@rzaharia rzaharia changed the title Dissasm view Dissasm fix some bugs with comments Mar 8, 2024
@rzaharia rzaharia marked this pull request as draft March 8, 2024 23:48
@rzaharia rzaharia closed this Mar 9, 2024
@rzaharia rzaharia reopened this Mar 10, 2024
@rzaharia rzaharia marked this pull request as ready for review March 10, 2024 07:59
@rzaharia rzaharia changed the title Dissasm fix some bugs with comments Dissasm fix some bugs with comments and added automatic unit testing job Mar 10, 2024
@rzaharia
Copy link
Collaborator Author

Currently, unit tests only work for Debug builds. Will be fixed later in #260. The priority not is them to work, to guarantee that new features do not break the old behavior.

@rzaharia rzaharia merged commit ce49b39 into main Mar 10, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants