Use paths relative to the bundle on OS X #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm using this patchset already on MacOS as well as did a smoke test for my Debian. Needs further testing on other platforms that's why fast merging. But looks fine to me |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches try to fix the problems described in #507 for various plugins. They address only "serious" issues which prevent correct operation of the plugin like not locating .glade or .ui files, not "minor" problems like not showing documentation when clicking the Help button of the plugin.
There's the same function get_data_dir_path() in each plugin which locates the file in the correct directory for each platform. For OS X laucher script I added an environment variable GEANY_PLUGINS_SHARE_PATH which is set before the binary is started so it should be defined and can be used by the plugin.