GeanyLua: update for new Scintilla 3.10 #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geany 1.34 broke API by using Scintilla 3.10 that removes some long-deprecated messages. Update the list of available messages and version dependency accordingly.
|
@b4n |
b4n
added a commit
that referenced
this pull request
Sep 21, 2018
GeanyLua: update for new Scintilla 3.10
|
@Skif-off thanks for the review, and sorry not to have given you the time to submit yours ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Skif-off could you take a look, as you seem to be interested in GeanyLua?
This change is required for GeanyLua to build against current Geany master.
I'm not sure of the implication of the changes in messages arguments, but this is a GeanyLua API break as well so it might be alright anyway.