Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Nim to builtin filetype and use Scintilla Nim lexer for it #3648

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

techee
Copy link
Member

@techee techee commented Oct 23, 2023

In addition to JSON, the other lexer we don't use yet is for the Nim language (these are the only ones I'm aware of). I'm not a Nim language user myself but I tried to modify the external filetype config file to the internal one so most of the stuff is preserved and should work correctly.

@techee
Copy link
Member Author

techee commented Aug 11, 2024

In addition to #3171 I'd like to merge this PR too so there's a proper lexer for the Nim language. I just went through the PR and tested it a bit and all seems to work well.

Again, I'll wait for about a week for complaints and merge this afterwards.

(Misusing hot summer days where nobody pays attention to get some old patches of mine merged :-P.)

@elextr
Copy link
Member

elextr commented Aug 12, 2024

Conflicts need resolving.

Its meant to be long lazy summer days 😛

@techee
Copy link
Member Author

techee commented Aug 12, 2024

Conflicts need resolving.

I'm aware of that. But because I'll introduce other conflicts by merging #3171, I'll wait until that one is merged.

Its meant to be long lazy summer days 😛

Yeah, just merging stuff is lazy :-)

@elextr
Copy link
Member

elextr commented Aug 12, 2024

@techee
Copy link
Member Author

techee commented Aug 13, 2024

https://github.com/nim-lang/langserver

By the way I tried that one but it kept crashing for me and I didn't spend much time investigating what went wrong.

@elextr
Copy link
Member

elextr commented Aug 13, 2024

but it kept crashing for me and I didn't spend much time investigating what went wrong.

Ok, was just a suggestion since there is no ctags parser.

@techee techee merged commit 2522d6a into geany:master Aug 18, 2024
7 checks passed
@b4n b4n added this to the 2.1 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants