feat(code-backend) implemented extractors in backend to avoid accidental memory registry creation #4381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breathx
requested changes
Jan 13, 2025
core-backend/src/funcs.rs
Outdated
| .into_inner() | ||
| .map_err(Into::into) | ||
| }) | ||
| pub fn read(at: u32, buffer: Write) -> impl Syscall<Caller> { |
There was a problem hiding this comment.
isn't it a bug, changing order of args?
There was a problem hiding this comment.
Yeah, but no. The arguments are in reverse order, but there is no other way but to change the syscall signature, which is obviously not worth it.
let ptr = SyscallValue(args[1]).try_into()?;
let size = SyscallValue(args[0]).try_into()?;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3891
Implemented extractors as proposed in issue #3891
Extractors are used in methods with a variable number of arguments, while having a variable number of constructor arguments themselves.
After all extractors have been created, the MemoryAccessRegistry::pre_process() method is called
If the method did not need any extractors, the MemoryAccessRegistry::pre_process() method will not be called either