fix(sandbox): clear sandbox store inside a block #4420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # .
Relates #4192
This hack fixes the error:
HACK: It was discovered that starting with version 4.0, Wasmer experiences a slowdown
when creating a large number of memory/instances beyond a certain threshold.
The usual method to clear the store doesn't work for benchmarks (see
Sandboxes::get
)or when too many instances/memories are created within a single block, as the store
is only cleared at the start of a new block.
This is a temporary solution to reset the store after reaching a certain limit
(see
SANDBOX_STORE_CLEAR_COUNTER_LIMIT
) for memory/instances.Otherwise, the store grows too large, leading to performance degradation during
normal node execution and benchmarks.
@reviewer-or-team