Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ethexe): simplify program creation and message sending in tests #4455

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

refactor(ethexe): simplify program creation and message sending in tests #4455

wants to merge 6 commits into from

Conversation

playX18
Copy link
Member

@playX18 playX18 commented Jan 20, 2025

  • Updated test cases to remove unnecessary payload and value parameters in create_program calls.
  • Replaced direct assertions on initialization message properties with assertions on reply messages.

@playX18
refactor(ethexe): simplify program creation and message sending in te…
ed7cc8b 
…st cases

- Updated test cases to remove unnecessary payload and value parameters in `create_program` calls.
- Replaced direct assertions on initialization message properties with assertions on reply messages.
@playX18 playX18 added the A0-pleasereview PR is ready to be reviewed by the team label Jan 20, 2025
@playX18 playX18 requested a review from breathx January 20, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx Awaiting requested review from breathx

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@playX18