refactor(core): Implement LimitedIntervalsTree and MaxEncodedLen for JournalNote #4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JournalNote - Added new type to core: `LimitedIntervalsTree` which is based on `IntervalsTree` but checks limits before inserting intervals. It implements `MaxEncodedLen` - Added type-alias `WasmPagesIntervalsTree` which is `LimitedIntervalsTree<WasmPage, PayloadSizeError, u16::MAX/2+1>`. - Changed most of the code to use `WasmPagesIntervalsTree` instead of unlimited `IntervalsTree` - Implemented MaxEncodedLen for `JournalNote` - Test that `JournalNote`, when encoded is less than 32MiB in size
playX18
changed the title
playX18
added
A1-inprogress
playX18
requested review from
breathx and
grishasobol
and removed request for
breathx
playX18
added
A0-pleasereview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
LimitedIntervalsTreewhich is based onIntervalsTreebut checks limits before inserting intervals. It implementsMaxEncodedLenWasmPagesIntervalsTreewhich isLimitedIntervalsTree<WasmPage, PayloadSizeError, u16::MAX/2+1>.WasmPagesIntervalsTreeinstead of unlimitedIntervalsTreeJournalNoteJournalNote, when encoded is less than 32MiB in sizeTto bewhere [T]: AsRef<[u8]>: this allows us to debug/display LimitedVec with anyTthat implements corresponding trait.Notes
IntervalsTreecan be a separate PR. Only public APIs were updated to convert IntervalsTree to LimitedIntervalTree.@breathx