Skip to content

Commit

Permalink
Add with_weight extrinsic (paritytech#12848)
Browse files Browse the repository at this point in the history
* add with weight extrinsic

* improve test
  • Loading branch information
shawntabrizi authored and ark0f committed Feb 27, 2023
1 parent 0e1d9c0 commit 610d7d9
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 0 deletions.
17 changes: 17 additions & 0 deletions frame/utility/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,23 @@ pub mod pallet {
let base_weight = T::WeightInfo::batch(calls_len as u32);
Ok(Some(base_weight.saturating_add(weight)).into())
}

/// Dispatch a function call with a specified weight.
///
/// This function does not check the weight of the call, and instead allows the
/// Root origin to specify the weight of the call.
///
/// The dispatch origin for this call must be _Root_.
#[pallet::weight((*_weight, call.get_dispatch_info().class))]
pub fn with_weight(
origin: OriginFor<T>,
call: Box<<T as Config>::RuntimeCall>,
_weight: Weight,
) -> DispatchResult {
ensure_root(origin)?;
let res = call.dispatch_bypass_filter(frame_system::RawOrigin::Root.into());
res.map(|_| ()).map_err(|e| e.error)
}
}
}

Expand Down
27 changes: 27 additions & 0 deletions frame/utility/src/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -901,3 +901,30 @@ fn batch_all_works_with_council_origin() {
));
})
}

#[test]
fn with_weight_works() {
new_test_ext().execute_with(|| {
let upgrade_code_call =
Box::new(RuntimeCall::System(frame_system::Call::set_code_without_checks {
code: vec![],
}));
// Weight before is max.
assert_eq!(upgrade_code_call.get_dispatch_info().weight, Weight::MAX);
assert_eq!(
upgrade_code_call.get_dispatch_info().class,
frame_support::dispatch::DispatchClass::Operational
);

let with_weight_call = Call::<Test>::with_weight {
call: upgrade_code_call,
weight: Weight::from_parts(123, 456),
};
// Weight after is set by Root.
assert_eq!(with_weight_call.get_dispatch_info().weight, Weight::from_parts(123, 456));
assert_eq!(
with_weight_call.get_dispatch_info().class,
frame_support::dispatch::DispatchClass::Operational
);
})
}

0 comments on commit 610d7d9

Please sign in to comment.