Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing: --show-unique-jobs explainer in gearadmin --help #335

Closed
octavn opened this issue May 16, 2022 · 2 comments
Closed

Confusing: --show-unique-jobs explainer in gearadmin --help #335

octavn opened this issue May 16, 2022 · 2 comments

Comments

@octavn
Copy link

octavn commented May 16, 2022

From the gearadmin --help output one might get the impression that gearman does not deduplicate jobs and that it holds internally a number of jobs that could be greater than the number of unique jobs (all-duplicate=unique):

  --show-unique-jobs             Show unique jobs on server.
  --show-jobs                    Show all jobs on the server.

The gearadmin --show-unique-jobs command collects the unique jobs information from the show unique jobs command available in the gearmand TEXT protocol which "List all of the unique job ids that the server currently is processesing or waiting to process.".

To avoid/remove the confusion, the above one liner explanation for --show-unique-jobs should be changed to "Show the unique ids for the jobs on the server" in https://github.com/gearman/gearmand/blob/master/bin/gearadmin.cc#L142.

@octavn octavn changed the title Confusing --show-unique-jobs explainer in gearadmin --help Confusing: --show-unique-jobs explainer in gearadmin --help May 16, 2022
@esabol
Copy link
Member

esabol commented May 16, 2022

I concur and have submitted PR #336 to address this issue.

@esabol
Copy link
Member

esabol commented Jun 3, 2022

Fix merged. Closing.

@esabol esabol closed this as completed Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants