Issue 278: Fix crashing in libtest/http.cc when '-Wp,-D_GLIBCXX_ASSERTIONS' is given

[esabol]

This PR fixes the problems in libtest/http.cc when you compile with CXXFLAGS=-'-Wp,-D_GLIBCXX_ASSERTIONS' on Fedora 31. Refer to issue #278 (and issue #275).

[esabol]

Please restart the following Travis CI jobs:
https://travis-ci.org/gearman/gearmand/jobs/653265367
https://travis-ci.org/gearman/gearmand/jobs/653265370
I believe the test failures with these are spurious. Thanks!

[cheese]

LGTM

[p-alik]

It would be good to replace &_body[0] by _body.data() at least in both if (HAVE_LIBCURL && _body.size()) blocks.

[esabol]

It would be good to replace &_body[0] by _body.data() at least in both if (HAVE_LIBCURL && _body.size()) blocks.

Why would that be better? I don't see it.

[p-alik]

c++ type should be treated with well-defined type methods

gearmand/libtest/vchar.hpp

Line 50 in a6bd168

typedef std::vector<char> vchar_t;

In my opinion mixing pure c and c++ style is inappropriate.

[esabol]

In my opinion mixing pure c and c++ style is inappropriate.

Well, that seems to be a separate issue then that should go in a separate PR.

[esabol]

Would it be OK if I merged this?

[p-alik]

I've no objections

[SpamapS]

GMTA @p-alik :)