Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfiles for testing and for a working example #327

Merged
merged 4 commits into from
Nov 13, 2022

Conversation

esabol
Copy link
Member

@esabol esabol commented Oct 22, 2021

@SpamapS wrote:

The Dockerfiles like the one above have been useful for me. Can you submit it as Dockerfile in the repo root?

I meant to add these over a year ago, but I'm just getting around to creating the PR now. Sorry. Better late than never, I hope.

Copy link
Member

@SpamapS SpamapS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that's quite a matrix of dockerfiles. I wonder if we should try to reduce some of the duplication. Will ponder.

docker/example/gearmand/Dockerfile Show resolved Hide resolved
@SpamapS
Copy link
Member

SpamapS commented Oct 23, 2021 via email

@SpamapS
Copy link
Member

SpamapS commented Jun 2, 2022

Hey @esabol I'm not entirely sure I have time to scrutinize this but it does look interesting. Let's take a look after we get 1.1.20 out.

sfinktah added a commit to sfinktah/gearmand that referenced this pull request Sep 23, 2022
@SpamapS
Copy link
Member

SpamapS commented Nov 13, 2022

I played around with these last night and they're pretty handy.

@SpamapS SpamapS merged commit 44d5866 into gearman:master Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants