Use _exit() in fork test to fix race #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Been doing some analysis. So what happens is this:
1) child forks, which ends up with the same socket for both child and parent.
1-parent) parent calls waitpid to wait for child to exit
2) child successfully echoes
3) child calls exit() which calls some registered atexit handler which
shuts down the shared connection
4) parent wakes up, sees client was successful, tries to use the same
connection socket which was just shut down.
I don't know how this test worked ever. But most likely there was a race
between the SIGCHLD and the exit handlers, and that may have been fixed
in recent libc's.
Closes #44
|
Thanks for testing! Travis agrees, and my tests on 14.04 and 16.04 have been successful. I'dlove to get a test up for centos/fedora too. |
|
Modification tested on RHEL/CentOS 7.2... The test passes now! Cool beans. |
esabol
pushed a commit
to esabol/gearmand
that referenced
this pull request
Mar 23, 2017
Been doing some analysis. So what happens is this:
1) child forks, which ends up with the same socket for both child and parent.
1-parent) parent calls waitpid to wait for child to exit
2) child successfully echoes
3) child calls exit() which calls some registered atexit handler which
shuts down the shared connection
4) parent wakes up, sees client was successful, tries to use the same
connection socket which was just shut down.
I don't know how this test worked ever. But most likely there was a race
between the SIGCHLD and the exit handlers, and that may have been fixed
in recent libc's.
Closes gearman#44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been doing some analysis. So what happens is this:
1-parent) parent calls waitpid to wait for child to exit
shuts down the shared connection
connection socket which was just shut down.
I don't know how this test worked ever. But most likely there was a race
between the SIGCHLD and the exit handlers, and that may have been fixed
in recent libc's.
Closes #44