Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to use the column names #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

remi-braun
Copy link

For my usecase it has been proven useful to plot the column names instead of the chunk_size:

2022-11-16_17h18_18

@remi-braun
Copy link
Author

Maybe linked to #34 ?

@gecko984 gecko984 linked an issue Nov 17, 2022 that may be closed by this pull request
@gecko984
Copy link
Owner

Hey Rémi, thank you for the PR. tThis is indeed exactly what is suggested in issue #34
I'm not too sure about the implementation you suggested, because it will prove useful in a very small number of cases - namely, when all the sets are really small, like 1-2 items, and also the items' string representatation must be short. I think, at least the items names should be rotated 90 degrees. And the existing parameter rotate_col_annotations won't work here, because it will rotate the whole ', '.join(names) instead each of the names individually.

Also I wrote a couple more things in the code comments, otherwise I'll happily accept this PR

@remi-braun
Copy link
Author

Hello,
I made another commit to take your comment into account, but sadly I haven't anytime left to spend on this PR.
Feel free to modify it as you want 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to show chunk contents on the bottom of the chart
2 participants