-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New format drivers #96
Open
jaideep777
wants to merge
12
commits into
geco-bern:v4_updates_jjoshi
Choose a base branch
from
jaideep777:phydro_drivers
base: v4_updates_jjoshi
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New format drivers #96
jaideep777
wants to merge
12
commits into
geco-bern:v4_updates_jjoshi
from
jaideep777:phydro_drivers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! It would be safer if your point about the separated downsampling is implemented in your fork before merging the pull request. We will have to avoid the files with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a flexible downsampling routine that takes 4 options: legacy, 24hr, daytime, 3hrmax. It facilitates writing all of these in the rsofun drivers dataset. It is currently fully backwards compatible.
The revised downsampler and rsofun formatter are implemented in *_phydro.R files. This is because the original fdk_downsample_fluxnet and fdk_format_drivers scripts are used also elsewhere in the code.
I suggest you cleanly separate the downsampling step into a numbers analysis step after the fdk data collection step. Currently, the data collection step writes both hh and dd files. It might be better if it wrote only hh files, and dd files are generated in the separate downsampling step.