Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 01 #22

Merged
merged 15 commits into from
Sep 24, 2024
Merged

Feature 01 #22

merged 15 commits into from
Sep 24, 2024

Conversation

Vitalii-250885
Copy link
Collaborator

@Vitalii-250885 Vitalii-250885 commented Sep 19, 2024

I complited:

Issue 1.1: Create a responsive layout for the header.
Issue 1.2: Implement the header with gradient color fill.
Issue 1.3: Add the subheader with appropriate styling.
Issue 1.4: Add a NextUI button as an anchor link to the contact form.
Issue 1.5: Implement background design for the header block.

Issue 2.1: Implement button group using NextUI with anchor links for each section.
Issue 2.2: Add the main introduction text for the site.
Issue 2.3: Add the logo to the block.

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for gecraft ready!

Name Link
🔨 Latest commit b6ef4da
🔍 Latest deploy log https://app.netlify.com/sites/gecraft/deploys/66f299eda4a6200008ff2321
😎 Deploy Preview https://deploy-preview-22--gecraft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/components/App.jsx Outdated Show resolved Hide resolved
src/components/App.jsx Outdated Show resolved Hide resolved
@Vitalii-250885
Copy link
Collaborator Author

I complited:

Issue 1.1: Create a responsive layout for the header.
Issue 1.2: Implement the header with gradient color fill.
Issue 1.3: Add the subheader with appropriate styling.
Issue 1.4: Add a NextUI button as an anchor link to the contact form.
Issue 1.5: Implement background design for the header block.

Issue 2.1: Implement button group using NextUI with anchor links for each section.
Issue 2.2: Add the main introduction text for the site.
Issue 2.3: Add the logo to the block.

Copy link
Collaborator

@Valyukhov Valyukhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Проверил, есть комментарии

src/App.jsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@Valyukhov Valyukhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Valyukhov
Copy link
Collaborator

Когда нажимаю на кнопку - то появляется предупреждение в консоли
image
Посмотрел в Nextui - они вроде как решили эту проблему на прошлой неделе
heroui-inc/heroui#3569
Проверь у себя локально, если есть предупреждение - обновись до версии 2.4.8
затем покликай и проверь ещё раз, если не уйдёт, сделаем issue и оставим пока, чтобы тебя не тормозило

href="#"
as={Link}
>
<img src="img/logo.svg" alt="" className="h-14 w-14" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt=""

Copy link
Collaborator

@Pavel064 Pavel064 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vitalii-250885 Vitalii-250885 merged commit cd786ce into main Sep 24, 2024
4 checks passed
@Vitalii-250885 Vitalii-250885 deleted the feature-01 branch September 24, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment