Fix single quotes not working on Windows (#40)

* Fix single quotes not working on Windows

* Note down what to test before release

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+## Unreleased
+
+- Execute shell commands under `powershell.exe` on Windows. This addresses Command Prompt not supporting queries wrapped in single quotes.
+
 ## 2023.9.0
 
 - Fixed `readtags` command failing when a symbol query contains non-alphanumeric characters.

NOTES.md

@@ -7,6 +7,10 @@
 1. `make package`
 1. `code --install-extension ctags-companion-2023.9.0-beta.vsix`
 1. Manually test the extension on a few projects
+    1. Rebuild ctags task
+    1. Go to Symbol in Workspace
+    1. Go to Symbol in File
+    1. Go to Definition
 
 ## Release checklist
 

src/helpers.js

@@ -99,12 +99,18 @@ function findField(tags, prefix) {
     return tag && tag.substring(prefix.length);
 }
 
-function wrapExec(exec) {
+function wrapExec(exec, platform = process.platform) {
     const outputChannel = vscode.window.createOutputChannel(EXTENSION_NAME);
-    return async (...args) => {
+    return async (command, options) => {
         try {
-            outputChannel.appendLine(args[0]);
-            const { stdout } = await exec(...args);
+            if (platform === "win32") {
+                // Use PowerShell on Windows because Command Prompt does not support single quotes
+                options = {...options, shell: "powershell.exe"}
+            }
+
+            outputChannel.appendLine(`${command} ${JSON.stringify(options)}`);
+
+            const { stdout } = await exec(command, options);
             const output = stdout.trim();
             return output ? output.split('\n') : [];
         } catch ({ message }) {

src/helpers.test.js

@@ -108,4 +108,20 @@ describe('wrapExec', () => {
         expect(result).toEqual([]);
         expect(vscode.window.showErrorMessage).toHaveBeenCalledWith("Ctags Companion: epic fail");
     });
+
+    it.each([
+        ["win32", "powershell.exe"],
+        ["darwin", undefined],
+        ["linux", undefined]
+    ])('uses powershell in windows', async (platform, expectedShell) => {
+        let shellUsed = undefined;
+
+        const exec = async (_, { shell }) => {
+            shellUsed = shell;
+            return { stdout: "OK" };
+        };
+
+        await wrapExec(exec, platform)("fakecommand", {});
+        expect(shellUsed).toEqual(expectedShell);
+    });
 });