Log errors to output channel instead of a toast message (#46)

* Log errors to output channel instead of a toast message

* Update CHANGELOG.md

* Check last call to output channel

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+## Unreleased
+
+- `readtags` and `ctags` execution errors are now logged to "Ctags Companion" output channel instead of toast notifications.
+
 ## 2023.10.2
 
 - Removed reference to no longer functional reindex command.

src/__mocks__/vscode.js

@@ -29,11 +29,13 @@ const workspace = {
 console.assert(workspace.asRelativePath({ fsPath: "/test/foo" }) == "foo");
 console.assert(workspace.asRelativePath({ fsPath: "/elsewhere/bar" }) == "/elsewhere/bar");
 
+const mockOutputChannel = {
+    appendLine: jest.fn(),
+};
+
 const window = {
     showErrorMessage: jest.fn(),
-    createOutputChannel: () => ({
-        appendLine() { }
-    })
+    createOutputChannel: () => mockOutputChannel
 };
 
 function Position(line, character) {

src/helpers.js

@@ -99,13 +99,14 @@ function findField(tags, prefix) {
     return tag && tag.substring(prefix.length);
 }
 
+const outputChannel = vscode.window.createOutputChannel(EXTENSION_NAME);
+
 function wrapExec(exec, platform = process.platform) {
-    const outputChannel = vscode.window.createOutputChannel(EXTENSION_NAME);
     return async (command, options) => {
         try {
             if (platform === "win32") {
                 // Use PowerShell on Windows because Command Prompt does not support single quotes
-                options = {...options, shell: "powershell.exe"}
+                options = { ...options, shell: "powershell.exe" };
             }
 
             outputChannel.appendLine(`${command} ${JSON.stringify(options)}`);
@@ -114,7 +115,7 @@ function wrapExec(exec, platform = process.platform) {
             const output = stdout.trim();
             return output ? output.split('\n') : [];
         } catch ({ message }) {
-            vscode.window.showErrorMessage(`${EXTENSION_NAME}: ${message}`);
+            outputChannel.appendLine(message);
             return [];
         }
     };

src/helpers.test.js

@@ -104,9 +104,10 @@ describe('wrapExec', () => {
         };
 
         const result = await wrapExec(exec)();
-
         expect(result).toEqual([]);
-        expect(vscode.window.showErrorMessage).toHaveBeenCalledWith("Ctags Companion: epic fail");
+
+        const outputChannel = vscode.window.createOutputChannel();
+        expect(outputChannel.appendLine).toHaveBeenLastCalledWith("epic fail");
     });
 
     it.each([