Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the geemap module #1544

Merged
merged 15 commits into from
May 30, 2023
Merged

Simplify the geemap module #1544

merged 15 commits into from
May 30, 2023

Conversation

giswqs
Copy link
Member

@giswqs giswqs commented May 29, 2023

This PR simplifies the Map class geemap module, making the widgets modular so that each widget can be added/removed programmatically

@github-actions
Copy link

github-actions bot commented May 29, 2023

@github-actions github-actions bot temporarily deployed to pull request May 29, 2023 18:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 29, 2023 19:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 29, 2023 19:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 29, 2023 23:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 29, 2023 23:26 Inactive
@giswqs
Copy link
Member Author

giswqs commented May 30, 2023

@jdbcode The inspector GUI has been separated from the Map.__init__() method. It can now be activated as follows:

Map.add_inspector()

inspector

@github-actions github-actions bot temporarily deployed to pull request May 30, 2023 02:02 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 30, 2023 02:12 Inactive
@giswqs
Copy link
Member Author

giswqs commented May 30, 2023

The Layer Manager GUI has been separated from the Map.__init__() method. It can now be activated as follows:

Map.add_layer_manager()

Peek 2023-05-29 22-46

@github-actions github-actions bot temporarily deployed to pull request May 30, 2023 02:52 Inactive
@giswqs
Copy link
Member Author

giswqs commented May 30, 2023

After separating the Inspector GUI and Layer Manager GUI from Map class, the number of lines of source code for the Map.__init__() method has been reduced from 1377 lines to 695 lines, almost 50% reduction. The widgets are now much easier to manage.

@github-actions github-actions bot temporarily deployed to pull request May 30, 2023 03:19 Inactive
@giswqs giswqs merged commit 567a939 into master May 30, 2023
@giswqs giswqs deleted the simplify branch May 30, 2023 03:50
@github-actions github-actions bot temporarily deployed to pull request May 30, 2023 03:59 Inactive
@giswqs giswqs mentioned this pull request May 30, 2023
@jdbcode
Copy link
Collaborator

jdbcode commented May 31, 2023

This is great! The simplification of the Map class is awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants