Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coreutils module #2126

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Add coreutils module #2126

merged 4 commits into from
Sep 20, 2024

Conversation

giswqs
Copy link
Member

@giswqs giswqs commented Sep 7, 2024

  • Creates the coreutils module by extracting functions that core modules rely on from the common module.
  • Replaces from . import common with from . import coreutils
  • Replaces function calls common.*** with coreutils.***
  • Adds typehints and docstrings to all functions in coreutils
  • Add coreutils module to mkdocs

@giswqs giswqs requested review from naschmitz and jdbcode September 7, 2024 02:24
Copy link

github-actions bot commented Sep 7, 2024

@github-actions github-actions bot temporarily deployed to pull request September 7, 2024 02:31 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 7, 2024 02:40 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 7, 2024 03:44 Inactive
@giswqs
Copy link
Member Author

giswqs commented Sep 19, 2024

@naschmitz This is test

@github-actions github-actions bot temporarily deployed to pull request September 19, 2024 15:54 Inactive
Copy link
Collaborator

@naschmitz naschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! Thank you so much!

@giswqs giswqs merged commit c4bc69b into master Sep 20, 2024
14 checks passed
@giswqs giswqs deleted the core branch September 20, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants