Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename get_api_key to get_env_var #2151

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

naschmitz
Copy link
Collaborator

@naschmitz naschmitz commented Oct 9, 2024

  • Renames the get_api_key function in coreutils.py to get_env_var to make it more generic and applicable to a wider range of use cases.
  • Adds test cases in test_coreutils.py.

Renames the `get_api_key` function in `coreutils.py` to `get_environment_variable` to make it more generic and applicable to a wider range of use cases.
@naschmitz naschmitz added the cleanup Minor issues (not: bug, enhancement, feature request) label Oct 9, 2024
@naschmitz naschmitz requested review from schwehr and giswqs October 9, 2024 02:18
@giswqs
Copy link
Member

giswqs commented Oct 9, 2024

The function name get_environment_variable seems a bit lengthy. How about get_env_variable or get_env_var?

@naschmitz naschmitz changed the title Rename get_api_key to get_environment_variable Rename get_api_key to get_env_var Oct 9, 2024
@naschmitz
Copy link
Collaborator Author

The function name get_environment_variable seems a bit lengthy. How about get_env_variable or get_env_var?

Done!

@naschmitz naschmitz merged commit 99de732 into gee-community:master Oct 10, 2024
15 checks passed
@naschmitz naschmitz deleted the coreutils branch October 10, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor issues (not: bug, enhancement, feature request)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants