Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing build #6

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Fix failing build #6

merged 3 commits into from
Nov 21, 2023

Conversation

dominykas
Copy link
Contributor

@dominykas dominykas commented Nov 20, 2023

  • removes dependency cache (that relies on the lock file, which I'm not sure you want here, but also not sure the cache would save enough to be worth it)
  • adds Node.js 20 to the matrix
  • ignores the globals added in the new Node.js versions
    • these are now available in the latest @hapi/lab, but I wasn't sure an upgrade is in order just yet?
    • belly-button and @hapi/code also have new majors available...
    • however bumping to require minimum Node.js 14, whereas previous .travis.yaml says Node.js 8 would require a major bump here? Which is maybe the plan anyways? @hapi/lab@latest does support Node.js 14, so it should be fine from that perspective...
  • removes .travis.yaml - it doesn't do anything anymore

Dependency cache requires a lock file - there isn't one here.
This would work better with upgraded libraries, but not sure that's desirable just yet.
@geek geek merged commit cf8d2a7 into geek:master Nov 21, 2023
4 checks passed
@dominykas
Copy link
Contributor Author

Any chance for a new release? 😁

@geek
Copy link
Owner

geek commented Nov 22, 2023

@dominykas published as v4.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants