LLMConfig add seed #1311
Merged
LLMConfig add seed #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekan
reviewed
Jun 1, 2024
| @@ -76,6 +77,7 @@ class LLMConfig(YamlModel): | |||
| best_of: Optional[int] = None | |||
| n: Optional[int] = None | |||
| stream: bool = True | |||
| seed: Optional[int] = None | |||
There was a problem hiding this comment.
If you just add the seed here but don't use it in the code, it won't take effect.
geekan
approved these changes
Oct 20, 2024
|
注意到底层逻辑没有实现，这里单独增加 seed 是没用的。如果你有时间，希望你可以补齐底层逻辑 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features: LLMConfig add seed