fixbug: #1422 Role's validate_role_extra resets watch in Environment obj deserialization #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixbug: TypeError: _evaluate() got an unexpected keyword argument 'recursive_guard'
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
=======================================
Coverage 62.59% 62.59%
=======================================
Files 287 287
Lines 17551 17552 +1
=======================================
+ Hits 10986 10987 +1
Misses 6565 6565 ☔ View full report in Codecov by Sentry. |
iorisa
changed the title
iorisa
requested review from
better629,
shenchucheng,
geekan and
garylin2099
and removed request for
better629
better629
reviewed
Aug 7, 2024
| @@ -68,7 +68,7 @@ class RoleA(Role): | |||
| def __init__(self, **kwargs): | |||
| super(RoleA, self).__init__(**kwargs) | |||
| self.set_actions([ActionPass]) | |||
| self._watch([UserRequirement]) | |||
| self._watch([FixBug]) | |||
There was a problem hiding this comment.
Do you run the all tests under tests/metagpt/serialize_deserialize to test this change.
There was a problem hiding this comment.
2024-08-07 14:55:21.127 | WARNING | tests.mock.mock_llm:_mock_rsp:121 - Use response cache
======================================================================================================= short test summary info ========================================================================================================
PASSED tests/metagpt/serialize_deserialize/test_action.py::test_action_serdeser
PASSED tests/metagpt/serialize_deserialize/test_architect.py::test_architect_serdeser
PASSED tests/metagpt/serialize_deserialize/test_environment.py::test_env_serdeser
PASSED tests/metagpt/serialize_deserialize/test_environment.py::test_environment_serdeser
PASSED tests/metagpt/serialize_deserialize/test_environment.py::test_environment_serdeser_v2
PASSED tests/metagpt/serialize_deserialize/test_environment.py::test_environment_serdeser_save
PASSED tests/metagpt/serialize_deserialize/test_memory.py::test_memory_serdeser
PASSED tests/metagpt/serialize_deserialize/test_memory.py::test_memory_serdeser_save
PASSED tests/metagpt/serialize_deserialize/test_polymorphic.py::test_serialize_as_any
PASSED tests/metagpt/serialize_deserialize/test_polymorphic.py::test_no_serialize_as_any
PASSED tests/metagpt/serialize_deserialize/test_polymorphic.py::test_polymorphic
PASSED tests/metagpt/serialize_deserialize/test_prepare_interview.py::test_action_serdeser
PASSED tests/metagpt/serialize_deserialize/test_product_manager.py::test_product_manager_serdeser
PASSED tests/metagpt/serialize_deserialize/test_project_manager.py::test_project_manager_serdeser
PASSED tests/metagpt/serialize_deserialize/test_reasearcher.py::test_tutorial_assistant_serdeser
PASSED tests/metagpt/serialize_deserialize/test_role.py::test_roles
PASSED tests/metagpt/serialize_deserialize/test_role.py::test_role_subclasses
PASSED tests/metagpt/serialize_deserialize/test_role.py::test_role_serialize
PASSED tests/metagpt/serialize_deserialize/test_role.py::test_engineer_serdeser
PASSED tests/metagpt/serialize_deserialize/test_role.py::test_role_serdeser_save
PASSED tests/metagpt/serialize_deserialize/test_role.py::test_role_serdeser_interrupt
PASSED tests/metagpt/serialize_deserialize/test_schema.py::test_message_serdeser_from_create_model
PASSED tests/metagpt/serialize_deserialize/test_schema.py::test_message_without_postprocess
PASSED tests/metagpt/serialize_deserialize/test_schema.py::test_message_serdeser_from_basecontext
PASSED tests/metagpt/serialize_deserialize/test_sk_agent.py::test_sk_agent_serdeser
PASSED tests/metagpt/serialize_deserialize/test_team.py::test_team_deserialize
PASSED tests/metagpt/serialize_deserialize/test_team.py::test_team_serdeser_save
PASSED tests/metagpt/serialize_deserialize/test_team.py::test_team_recover
PASSED tests/metagpt/serialize_deserialize/test_team.py::test_team_recover_save
PASSED tests/metagpt/serialize_deserialize/test_team.py::test_team_recover_multi_roles_save
PASSED tests/metagpt/serialize_deserialize/test_team.py::test_context
PASSED tests/metagpt/serialize_deserialize/test_tutorial_assistant.py::test_tutorial_assistant_serdeser
PASSED tests/metagpt/serialize_deserialize/test_write_code.py::test_write_design_serdeser
PASSED tests/metagpt/serialize_deserialize/test_write_code.py::test_write_code_serdeser
PASSED tests/metagpt/serialize_deserialize/test_write_code_review.py::test_write_code_review_serdeser
PASSED tests/metagpt/serialize_deserialize/test_write_design.py::test_write_design_serialize
PASSED tests/metagpt/serialize_deserialize/test_write_design.py::test_write_task_serialize
PASSED tests/metagpt/serialize_deserialize/test_write_docstring.py::test_action_serdeser[google]
PASSED tests/metagpt/serialize_deserialize/test_write_docstring.py::test_action_serdeser[numpy]
PASSED tests/metagpt/serialize_deserialize/test_write_docstring.py::test_action_serdeser[sphinx]
PASSED tests/metagpt/serialize_deserialize/test_write_prd.py::test_action_serdeser
PASSED tests/metagpt/serialize_deserialize/test_write_review.py::test_action_serdeser
PASSED tests/metagpt/serialize_deserialize/test_write_tutorial.py::test_write_directory_serdeser[English-Write a tutorial about Python]
PASSED tests/metagpt/serialize_deserialize/test_write_tutorial.py::test_write_content_serdeser[English-Write a tutorial about Python-directory0]
=================================================================================================== 44 passed, 5 warnings in 40.18s ====================================================================================================
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features