-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixbug: there's a problem about using external LLM of huoshan #1429 #1438
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1438 +/- ##
==========================================
- Coverage 62.62% 62.58% -0.04%
==========================================
Files 287 287
Lines 17564 17588 +24
==========================================
+ Hits 10999 11008 +9
- Misses 6565 6580 +15 ☔ View full report in Codecov by Sentry. |
@@ -16,11 +37,45 @@ class ArkLLM(OpenAILLM): | |||
见:https://www.volcengine.com/docs/82379/1263482 | |||
""" | |||
|
|||
aclient: Optional[AsyncArk] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ark has a openai compatible interface, should we use the official sdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, to support also ak/sk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The openai compatible interface is not working, so it's replaced by sdk.
@@ -187,6 +187,14 @@ | |||
"mixtral-8x7b": {"prompt": 0.4, "completion": 1.6}, | |||
} | |||
|
|||
# https://console.volcengine.com/ark/region:ark+cn-beijing/model | |||
DOUBAO_TOKEN_COSTS = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There also doubao-xx related token cost under TOKEN_COSTS
, you can delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm |
Features