Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ollama_api to add llava support #1544

Merged
merged 13 commits into from
Oct 30, 2024

Conversation

EvensXia
Copy link
Contributor

Features
fix ollama_api to add llava support

  • support llava calling in ollama
  • fix typehints and API calling in metagpt/provider/general_api_requestor.py
  • remove conflict overload typehints in metagpt/provider/general_api_base.py

This PR fixes #1539

@geekan
Copy link
Owner

geekan commented Oct 28, 2024

Great! Let’s take a look.

metagpt/provider/ollama_api.py Outdated Show resolved Hide resolved
metagpt/provider/ollama_api.py Outdated Show resolved Hide resolved
metagpt/provider/ollama_api.py Outdated Show resolved Hide resolved
metagpt/provider/ollama_api.py Outdated Show resolved Hide resolved
metagpt/provider/general_api_base.py Show resolved Hide resolved
@EvensXia
Copy link
Contributor Author

  • run in examples/llm_vision.py
    screenshot-20241029-161311
  • test in tests/metagpt/provider/test_ollama_api.py
    screenshot-20241029-161204

@geekan
Copy link
Owner

geekan commented Oct 30, 2024

Although it seems that the test case does not meet the submission requirements, I think a quick submission can be made first. You can add test cases later.

@geekan geekan merged commit 9db0874 into geekan:main Oct 30, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants