Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Refactor Message transmission & filtering. Implement RFC 116 #474

Merged
merged 117 commits into from
Dec 4, 2023
Merged

refactor: Refactor Message transmission & filtering. Implement RFC 116 #474

merged 117 commits into from
Dec 4, 2023

Conversation

iorisa
Copy link
Collaborator

@iorisa iorisa commented Nov 2, 2023 •
edited
Loading

refactor: According to rfc 116

莘权 马 added 30 commits October 31, 2023 15:23
refactor: Message
5e8ada5
refactor: Refactor Message transmission & filtering
545d77c
refactor: Refactor Message transmission & filtering
bd813d2
refactor: Refactor Message transmission & filtering
8582f21
refactor: Refactor Message transmission & filtering
d127586
feat: +unit test
d685252
feat: +unit tests
bfaeda0
refactor: rename async_put_message to put_message
bc1a757
feat: +unit tests
8572fa8
feat: + subscribe
660f788
feat: + subscribe
d5d520f
feat: + subscribe
5267510
feat: + subscribe
834c59d
feat: + subscribe
bc67109
feat: + subscribe
2e9a265
refactor: update notations
a7632e8
refactor: update notations
93eda7f
refactor: update notations
96f29da
refactor: update notations
e49f8a0
refactor: update notations
67f07b6
refactor: update notations
ddd2d40
refactor: update notations
a996440
refactor: update notations
6bd9a76
refactor: update notations
17c5f80
refactor: update notations
953a003
refactor: update notations
b1386a0
refactor: update notations
2904799
refactor: update notations
bdf59b6
refactor: update notations
4b6745b
refactor: update notations
2c551c1
@garylin2099
Copy link
Collaborator

LGTM

有一些优化或注意点可留到后续PR解决：

  1. 默认的subscribe行为，应该放subscribe函数内做，不放__init__内。默认subscribe可再考虑加个profile
  2. memory和long-term memories的add_news后续看是否要删掉
  3. 此PR混入了较多格式相关的改动，和主需求无关，在最终合入main前，要对main做一次格式化，再比对分支差异做一次review

@garylin2099
Copy link
Collaborator

新加的any_to_string得补下单测，并检查它在Role和Message内使用时得到的是不是想要的string，两者是否一致：
Role里any_to_string(self)
Message里any_to_string(某Role类)

@iorisa
Copy link
Collaborator Author

iorisa commented Nov 21, 2023

新加的any_to_string得补下单测，并检查它在Role和Message内使用时得到的是不是想要的string，两者是否一致： Role里any_to_string(self) Message里any_to_string(某Role类)

加到tests/metagpt/utils/test_common.py里了

garylin2099
garylin2099 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@garylin2099 garylin2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

geekan
geekan reviewed Nov 22, 2023
View reviewed changes
Copy link
Owner

@geekan geekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改符号、改格式等后续建议专门放在一个PR里

examples/agent_creator.py Outdated Show resolved Hide resolved
examples/agent_creator.py Outdated Show resolved Hide resolved
examples/agent_creator.py Outdated Show resolved Hide resolved
examples/agent_creator.py Outdated Show resolved Hide resolved
examples/agent_creator.py Outdated Show resolved Hide resolved
metagpt/roles/engineer.py Outdated Show resolved Hide resolved
metagpt/roles/engineer.py Outdated Show resolved Hide resolved
metagpt/roles/engineer.py Outdated Show resolved Hide resolved
metagpt/roles/role.py Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
@iorisa iorisa requested a review from geekan November 22, 2023 08:14
@iorisa iorisa mentioned this pull request Nov 27, 2023
Merged
@iorisa iorisa changed the title refactor: Refactor Message transmission & filtering refactor: Refactor Message transmission & filtering. implement RFC 116 Nov 28, 2023
@iorisa iorisa changed the title refactor: Refactor Message transmission & filtering. implement RFC 116 refactor: Refactor Message transmission & filtering. Implement RFC 116 Nov 28, 2023
garylin2099
garylin2099 reviewed Nov 28, 2023
View reviewed changes
metagpt/roles/role.py Outdated Show resolved Hide resolved
@garylin2099 garylin2099 merged commit b3aa0a7 into geekan:env_refactor Dec 4, 2023
@iorisa iorisa deleted the feature/refactor_shenquan branch December 13, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garylin2099 garylin2099 garylin2099 approved these changes

@stellaHSR stellaHSR Awaiting requested review from stellaHSR

@better629 better629 Awaiting requested review from better629

@femto femto Awaiting requested review from femto

@geekan geekan Awaiting requested review from geekan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iorisa @garylin2099 @femto @geekan @better629 @stellaHSR