feat: RFC116 & RFC135 #552
Conversation
… 113, the routing functionality is to be consolidated into the Environment class.
…ng opportunities - Modifided actions: project_management / design_api / write_prd
…ll method, fix quadrantChart in chinese etc.
Merge/geekan/main to env refactor
fixbug: single line block cause error
| from metagpt.repo_parser import RepoParser | ||
|
|
||
|
|
||
| def validate_cols(content_col: str, df: pd.DataFrame): |
There was a problem hiding this comment.
most content repeated with metagpt/document_store/document.py
There was a problem hiding this comment.
The two code files have different functionalities, and this has been annotated for clarification. metagpt/document_store/document.py is still under design; please ignore it for now.
|
|
||
|
|
||
| class RawMessage(TypedDict): | ||
| content: str | ||
| role: str | ||
|
|
||
|
|
||
| @dataclass | ||
| class Message: | ||
| class Document(BaseModel): |
There was a problem hiding this comment.
what's the difference with Document in metagpt/document.py and Document in metagpt/document_store/document.py
There was a problem hiding this comment.
Documentinshema.pyis a data structure in memory used to point to files in the file system.metagpt/document.pyrepresents IO layer files in the file system.metagpt/document_store/document.pyrepresents IO layer files in the vector database.
There was a problem hiding this comment.
maybe with different class name is more clear.
|
|
||
| async def run(self, n_round=3): | ||
| """Run company until target round or no money""" | ||
| while n_round > 0: | ||
| # self._save() | ||
| n_round -= 1 | ||
| logger.debug(f"{n_round=}") | ||
| logger.debug(f"max {n_round=} left.") |
There was a problem hiding this comment.
suggest logger.debug(f"max {n_round=} left.") before n_round -= 1, or it will print max n_round=0 left, but still to run the last round. It will make a mistake.
There was a problem hiding this comment.
what i mean is that n_round=0 means it won't run more round, but there still a last round to run now.
fixbug: The unit test code outputted by DebugError was mistakenly saved in the wrong file.
|
LGTM |
|
@garylin2099 Perhaps we could replace the link to RFC116 and RFC135, which are publicly accessible. |
feat: RFC116
feat: RFC135
SoftwareCompanyenhanced incremental iteration capability for meeting requirements, managing versions through Git.ProductManagerintroduced thePrepareDocumentsaction to create project environments like Git repositories.SummarizeCodeaction to inspect the code from a global perspective. Its execution can be limited by the--max-auto-summarize-codeparameter.RunCodeaction.中：
SoftwareCompany增加了需求的增量迭代能力，通过git管理版本。ProductManager新增PrepareDocumentsaction，用来创建git repository等项目环境；Engineer新增SummarizeCodeaction，从全局视角检查代码。可通过--max-auto-summarize-code参数限制其执行次数。RunCodeaction没有自动安装依赖包的问题。