feat: Merge the modifications resulting from integrating with the agent store. #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixbug: recursive search for provider
… geekan/v0.6-release
feat: Disable the DEFAULT_PROVIDER in console mode.
…re is nothing to do.
fixbug: an unexpected UserRequirement type message is thrown when there is nothing to do.
fixbug: unit test
fixbug: rename folder does not work in windows os
fixbug: fix todo_description
feat: Moderation + llm arg feat: +log
… geekan/v0.6-release
fixbug: RPC think
geekan
reviewed
Jan 18, 2024
metagpt/roles/role.py
Outdated
| @@ -524,6 +524,7 @@ def is_idle(self) -> bool: | |||
|
|
|||
| async def think(self) -> Action: | |||
| """The exported `think` function""" | |||
| await self._observe() | |||
There was a problem hiding this comment.
These interfaces are designed for use by the agent store.
In the early design of the agent store interface, the observation behavior was implemented externally through direct memory operations without being encapsulated into an "observe" interface.
To ensure compatibility, the observation behavior has now been incorporated into the "think" interface.
There was a problem hiding this comment.
There are still some counter-instincts in the think _observe, can you add the reason to the comments?
geekan
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Role.think()first_actiontoaction_descriptionnumpy==1.24.3tonumpy>=1.24.3