Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace CONTEXT with Context() #784

Merged
merged 8 commits into from
Jan 22, 2024
Merged

feat: Replace CONTEXT with Context() #784

merged 8 commits into from
Jan 22, 2024

Conversation

iorisa
Copy link
Collaborator

@iorisa iorisa commented Jan 22, 2024

Features
feat: Replace CONTEXT with Context()

  • The default CONTEXT is equal to Context().
  • Due to the unrestricted read and write access to the global variable CONTEXT, it resulted in uncontrolled propagation of changes. Therefore, this global variable has been deprecated.

From now, the Context object is uniformly created during scene initialization and implicitly passed through the object hierarchy. Examples can be found in the generate_repo function in startup.py.

geekan
geekan approved these changes Jan 22, 2024
View reviewed changes
Copy link
Owner

@geekan geekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geekan geekan merged commit 7f78c56 into geekan:dev Jan 22, 2024
1 of 2 checks passed
@iorisa iorisa deleted the feature/remove_global_context branch March 19, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekan geekan geekan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iorisa @geekan