Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #845

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Dev #845

merged 2 commits into from
Feb 6, 2024

Conversation

better629
Copy link
Collaborator

Features

  • fix RecursionError: maximum recursion depth exceeded while calling a Python object when run tests/metagpt/environment/test_base_env.py
  • add cache result for gpt-4v due to online unittest failed

Feature Docs

Influence

Result

(metagpt_v2) MacBook-Pro:MetaGPT xxx$ pytest tests/metagpt/environment/test_base_env.py
============================================================================== test session starts ===============================================================================
collected 1 item

tests/metagpt/environment/test_base_env.py .                                                                                                                               [100%]

================================================================================ warnings summary ================================================================================

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
========================================================================== 1 passed, 1 warning in 2.38s ==========================================================================

Other

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (23c2762) 83.31% compared to head (1855b2b) 82.73%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #845      +/-   ##
==========================================
- Coverage   83.31%   82.73%   -0.59%     
==========================================
  Files         225      225              
  Lines       12456    12456              
==========================================
- Hits        10378    10305      -73     
- Misses       2078     2151      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@geekan geekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geekan geekan merged commit 4616749 into geekan:dev Feb 6, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants