Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move the required playwright to requirements.txt #863

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

voidking
Copy link
Collaborator

@voidking voidking commented Feb 7, 2024

The main process depends on playwright.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7b5d3c) 83.77% compared to head (3b4379d) 82.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   83.77%   82.88%   -0.90%     
==========================================
  Files         225      225              
  Lines       12441    12441              
==========================================
- Hits        10423    10312     -111     
- Misses       2018     2129     +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

requirements.txt Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
@garylin2099
Copy link
Collaborator

LGTM

@geekan geekan merged commit b56f1bf into geekan:main Feb 7, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants