Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODE REFACTORIZATION #1955

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Conversation

OfficialAhmed
Copy link
Contributor

@OfficialAhmed OfficialAhmed commented Aug 1, 2023

CHANGED: 2 files missing .py extension

MERGED : pattern1.py and pattern3.py since they're implemented in a similar way.

The user can choose the pattern between:

  • repeat which repeats the pattern such as 111 22 3
  • incremental increments like 1 12 123

The user can choose the pattern position:

  • upper part
1
12
123
  • lower part
123
12
1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better if the name "half_triangle_pattern.py" instead of "half triangle pattern.py", the one in the beginning uses snake_case which adheres more to the best practices and standards of python programming language.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want your take @OfficialAhmed on naming file using snake_case as it is what is used in terms of python to name objects usually. So does naming files with that name adheres to the best practices and standards of python programming language? especially the files with extension ".py"

@geekcomputers geekcomputers merged commit f6e0961 into geekcomputers:master Aug 2, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants