-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Customisable expander #11
Conversation
Thanks a lot for your solution. Unfortunately when I updated to the latest version, I cannot compile anymore. Probably the problem is in my settings, but I can't find what is going on. Can you help me, please? Here is what I get: `Module parse failed: Unexpected token (10:16)
@ ./node_modules/cache-loader/dist/cjs.js??ref--13-0!./node_modules/thread-loader/dist/cjs.js!./node_modules/babel-loader/lib!./node_modules/cache-loader/dist/cjs.js??ref--1-0!./node_modules/vue-loader-v16/dist??ref--1-1!./src/components/DeviceTree.vue?vue&type=script&lang=js 2:0-40 9:4-15 |
Interesting... |
I worked with V1.0.17 without problems. Yesterday I just executed 'npm update vue3-tree-vue' and I got the latest version (exactly 1.0.20). I have no other changes, just tried to build and i got this problem. |
Having a look... I think we might be having a re-occurence of #1 which you raised a year ago. Can I have a look at your package.json and wepack.config (if any) ? Thanks |
Here is the content of my package.json (I just changed some texts): { |
Thanks, do you have a webpack config on the project ? |
No, I don't. |
Having a look... |
Hi! Did you find something concerning my problem? |
Hi @SciManJD , I am working on the v2.0 of this package to add other richer functionalities and better testing. |
Installing of the plugin that transpiles nullish coalescing operator didn't help. But I don't think that this is the problem in my case. Looking at the error, mentioned above, I don't see such operator. |
_item.children?.forEach(child => { |
OK! This is another variant of the nullish coalescing operator. But I intsalled plugin and changed my babel.config.json from: module.exports = { to: module.exports = { But I get the same error. I see that other people also couldn't solve the problem. Am I doing something wrong? |
Hard to say. For your sakes, I will remove the operator and publish an update today. Thanks |
Great. Thank you so much and sorry for the additional effort, but I really would like to have this new feature. |
Hi @SciManJD |
Hi! I installed the patched version with: I see now in my package.json the the version is changed: But when I build I set the following error: error in ./node_modules/vue3-tree-vue/dist/vue3-tree-vue.esm.js | state.emitItemCheckedChange(child); @ ./node_modules/cache-loader/dist/cjs.js??ref--13-0!./node_modules/thread-loader/dist/cjs.js!./node_modules/babel-loader/lib!./node_modules/cache-loader/dist/cjs.js??ref--1-0!./node_modules/vue-loader-v16/dist??ref--1-1!./src/components/DeviceTree.vue?vue&type=script&lang=js 2:0-40 9:4-15 |
Hard to say what is actually going on. I will try to get the next version out as soon as possible. But I can also look at this issue again during the weekend. Meanwhile how do you import this component ? import Vue3-tree-vue from 'vue3-tree-vue' or import Vue3-tree-vue from 'vue3-tree-vue/dist/...' |
@SciManJD after having a second, sorry third, sorry fourth look. We have 1.0.22. I have added a configuration to transpile the nullable operators. I also inspected the .dist folder to be sure you would not be having that in the build. I think that should solve the issue for you or anyone else. Please retest. |
I import it like this: I will test the new version immediately, but what to install a main-line or a patch? Please, write what to execute to avoid mistakes from my side... And another question, what is better, to uninstall the old version and to install the new one or just to update? |
I usually prefer to uninstall older versions first. But when I am in extreme doubt or when I am experiencing weird behaviours, I will;
Choice is yours. 🙂 |
Great news... Now I can build without any problems and then it works just fine. Thanks for the great job to support me... |
Great! |
Resolves #10
Usage