Add IPv6 support #25
Open
Add IPv6 support #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the return value from all functions, make sure to close the socket on error and make sure the sizeof() calls are consistent (sometime the type was used, sometimes the structs themselves).
This is in preparation for later patches.
This adds a double-linked list implementation taken from the Linux kernel.
This is in preparation for the next patch which switches to a poll()-based event loop.
This is a preparatory step to simplify the following changes.
For consistency with recv_sock and to make it clear that these structs have nothing to do with e.g. struct if_addr or struct in_addr.
This is just in preparation for further changes to send_sock and recv_sock.
There's still no support in the actual sending/receiving though.
After this change, we can actually receive IPv6 multicast mDNS packets, but just log and discard them (for now).
IP_MULTICAST_IF isn't FreeBSD specific and SO_BINDDEVICE is Linux-specific, so use IP_MULTICAST_IF for all platforms.
The function is incomplete (missing address/routes), but the sockets are not used yet.
This is in preparation for later patches adding multiple net/mask/addr triplets to send_sock() for IPv6.
IPv6 mDNS repetition actually works now :D
And introduce a helper function to match addresses to net/mask.
This is a bit more readable...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds IPv6 support to mdns-repeater.
I've broken it out into a long list of patches which kind of track the history of rewriting the daemon. In the process I've removed some hardcoded limitations (like the number of interfaces).
I realise that it might be a bit difficult to review the individual patches. It might be better to just read through
mdns-repeater.cwith the whole patchset applied.