Refactor tasks into shim roles #1327
Conversation
| - name: Define php_xhprof_html_dir. | ||
| set_fact: | ||
| php_xhprof_html_dir: "/usr/share/php/xhprof_html" | ||
| when: php_xhprof_html_dir is not defined |
There was a problem hiding this comment.
I almost moved this task but then realized it exists so that provisioning doesnt fail even if xhprof and the variable isn't available. 42d554d
|
Changing the PHP version with works, but you also have to manually empty the twig cache: rm -rf sites/default/files/php/twig/* |
oxyc
changed the title
In case xhprof isn not enabled but the default vhost is.
|
Heh, you've created quite the backlog of Travis CI jobs :) Thanks so much for the help—main suggestion would be you can update the 'Author' section to mention you instead of me (or if you insist, in addition to), since (a) you did this refactoring work, and (b) I think you probably wrote more of the tasks that found their ways into these particular roles! |
|
|
||
| ## Author Information | ||
|
|
||
| This role was created in 2017 by [Jeff Geerling](https://www.jeffgeerling.com/), author of [Ansible for DevOps](https://www.ansiblefordevops.com/). |
There was a problem hiding this comment.
Update these sections to mention something like "was created in 2017 by Oskar Schöldström".
Also, how do you pronounce your last name?
There was a problem hiding this comment.
Done, but I'll definitely leave you in the meta as I would be the most unreliable maintainer ever hehe. I prefer offloading it on to you 😄
Haha, the "ö" is pronounced like the "i" in bird. I'll listen in the next time there's a recorded session and check how well you do.
There was a problem hiding this comment.
I just spent the past 5 minutes trying to figure out how to pronounce the 'i' in bird... I just can't do it without saying "ir".
I also included e84af01 in this PR (sorry) beetboxvm/beetbox#359. I can remove that commit and open up a separate PR if you prefer an easier read.
Tested:
DRUPALVM_ANSIBLE_TAGS=php vagrant provisionDRUPALVM_ANSIBLE_TAGS=xdebug vagrant provisionDRUPALVM_ANSIBLE_TAGS=database vagrant provisionDRUPALVM_ANSIBLE_TAGS=webserver vagrant provision