This repository has been archived by the owner on Feb 13, 2023. It is now read-only.
Include php_xdebug_version in default.config.yml #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include php_xdebug_version in default.config.yml to provide visibility to this option
|
Just wondering, what's the impetus here (why did you need to change the version from the default)? |
@geerlingguy I found compatibility problems between the default version (2.6.0) and PHP 7.3. I struggled a bit to find a way to change that, so I thought adding it here would save others the time. |
|
I'll merge this in but I'll also set the default in the playbook since the version of PHP Drupal VM defaults to may shift from what the upstream role defaults to over time, and it's good to test the versions in lockstep. Note that the current upstream default is 2.9.0... |
geerlingguy
added a commit
that referenced
this pull request
Apr 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include php_xdebug_version in default.config.yml to provide visibility to this option.