Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Use composer project based site build as the default #701

Merged
merged 1 commit into from
Jun 6, 2016

Conversation

oxyc
Copy link
Collaborator

@oxyc oxyc commented Jun 5, 2016

@geerlingguy would you mind testing this to see how the performance has improved since #694 (comment)?

@oxyc
Copy link
Collaborator Author

oxyc commented Jun 5, 2016

If this turns out to be fast enough, should we use build_composer_project as the default so we can remove a bunch of steps from the quick start guide? Or should we just use build_composer and change everything to reference the example.drupal.composer.json instead of example.drupal.make.yml?

Another option for those who use Drupal VM as their base repository is to tell them to overwrite Drupal VM's composer.json, with drupal.composer.json. That makes a bit more sense and for this particular scenario I guess users don't care about keeping files unmodified...


I prefer using build_composer_project as the default because that means all you have to do to setup Drupal VM is:

brew install vagrant
git clone git@github.com:geerlingguy/drupal-vm.git
cd drupal-vm
vagrant up

@geerlingguy
Copy link
Owner

Yes! If the performance is close, let's use the simplest setup method.

@geerlingguy
Copy link
Owner

I'll try to run tests tonight, it's crepe night, so it'll have to wait a bit.

@geerlingguy
Copy link
Owner

geerlingguy commented Jun 6, 2016

(moved test results to issue thread)

@geerlingguy
Copy link
Owner

Testing is good, I'm going to include a default cachier config for #702 once I get a little more testing completed.

@geerlingguy geerlingguy closed this Jun 6, 2016
@geerlingguy geerlingguy reopened this Jun 6, 2016
@geerlingguy geerlingguy merged commit 88bfcf1 into geerlingguy:master Jun 6, 2016
@geerlingguy geerlingguy added this to the 3.1.0 milestone Jun 6, 2016
@oxyc oxyc deleted the composer-default branch April 24, 2017 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants