-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build and update to syn v2 #518
base: master
Are you sure you want to change the base?
Conversation
…-string literals `c""` https://doc.rust-lang.org/edition-guide/rust-2021/c-string-literals.html : thread '<unnamed>' panicked at /Users/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/syn-1.0.109/src/lit.rs:1020:13: Unrecognized literal: `c""`
…parse file: /Users/user/.cargo/git/checkouts/itertools-eb89fd56766bcf43/8761fbe/src/format.rs, Syn(Error("expected ','").
This PR keeps growing and growing as I fix more tests. I would love to hear suggestions for splitting it up. It would also be great if there was a way to get |
We're re-writing much of the core incl. to break the cargo-reliance so messy PR is ok for now to fix the techdebt np. Thanks so much for doing this 🚀 |
@@ -0,0 +1 @@ | |||
1.76 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning causes other problems. We can use rust-version in Cargo.toml for MSRV if we are to bump it.
EDIT: I misread your comment - yeah we need to address the core problem really. Thanks for identifying it.
This PR fixes #517 . Here's what it does
integration_tests__test9_package_with_git_deps.stdout.snap
to match a package version in Cargo.locksyn
v1 to v2 to support new C-style string literals. This fixes the panic:Unrecognized literal: c""
.cargo_metadata
crate to v0.18. This will require major changes to cargo-geiger's code.Problems in this PR: