Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rc/main stufe 4 #425

Closed
wants to merge 243 commits into from
Closed

Rc/main stufe 4 #425

wants to merge 243 commits into from

Conversation

f-peverali
Copy link
Contributor

@f-peverali f-peverali commented Jun 25, 2024 •
edited by patrick-werner
Loading

Stufen Upgrade

Version: 4.0.0-rc3

Diesen PR NICHT (nach mains-stufe-3) mergen !!!

Date: 25.6.2024

Description

This is a Pullreuqest that requires an increase in the Version number. Therefore, multiple outside-github, related Task have to be performed and checked.

All jobs with an x in the boxes were performed to the best of knowledge.

Pre-Merge Activities

  • This PR refers to a versioned Branch with a name and a version number in the form of N.n.n, e.g. "TC_3.2.1".
  • This PR has a clean meaningful commit history. Minor commits or commits without description have been squashed, at the latest now.
  • The ./github/workflows/main.yml refers to the correct Firely Terminal and SUSHI Version.
  • By running the Release_Publish.py script, release version and date was updated accordingly. The script ran without errors.
  • Eventually, increase the dependency of to newer Basis Modul (package and sushi-config)
  • New Release Notes were created, alined to the commit history and cleaned. In Github, go to
    • -> Releases then -> Draft a new release with the Modul Name and Version, then
    • -> Target the main-Branch and ->enter a new Tag according to the Version, then click.
    • Click -> Generate Release notes , ->Adjust them if necessary and -> Copy/Paste the Details in the RealeaseNotes.md of the very Branch you want to merge.
    • Finally -> Save as Draft

Merge and Publishing

  • With the updated Version, Dates, and Release Notes (as described above) with the last committ into the Branch you want to merge.
  • In GitHub -> Actions the ->CI (FHIR Validation) workflow terminates successfully.
  • Add the Approve / the PR gets positively reviewed by a colleague.
  • Merge (without squash) the PR, delete the Branch.

Post-Merge Activities

  • Go to the corresponding SIMPLIFIER Project and -> Github -> Reimport the project.
  • Go to the corresponding SIMPLIFIER Project and -> Packages -> Expand the Dropdown for Create -> Create new package for the project.
    • With the corresponding version number, and
    • The Release notes (from above) and a compare-link to the previous Release.
    • Unlist the old package by -> clicking on the old package, -> go to Administration and -> click on Unlist
  • Publish the previously drafted Release, including version number, on GitHub.
  • Provide / Archive the IG in the corresponding gh-pages branch of the GitHub project.
    • Checkout the Branch (no need to merge it later).
    • Export from Simplifier via -> Guides -> Expand the Modul ... -> Export
    • Unpack the zip, remove the packages folder (because its kinda big), and move everything else to a (version corresponding) new folder in the branch folder structure.
    • Update the file index.html and check rendering
    • commit the branch.
  • If ISiK Basismodul was updated all depending Modules should be updated with a renewed dependency to the incremented Basismodul version - possibly including and closing technical corrections

Finished

f-peverali and others added 30 commits January 16, 2024 14:16
@f-peverali
update version and status
75675bc
@f-peverali
auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)
a7a2cb3
@f-peverali
init ISIKOrganisation
cc91746
@f-peverali
auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)
1d67246
@f-peverali
add relevant identifier constraints
2edce92
@f-peverali
Merge branch 'feature/ISIK-Organization-PTData-521' of https://github…
0f74d23 
….com/gematik/spec-ISiK-Basismodul into feature/ISIK-Organization-PTData-521
@f-peverali
add interaction in .md + minor changes
a63cc47
@f-peverali
fix: remove KZV Abrechunugsnummer
cbad90f
@f-peverali
auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)
acc49f3
@f-peverali
init ISiKStandort
93f8196
@f-peverali
Merge branch 'feature/ISIK-Organization-PTData-521' of https://github…
4b3bb3b 
….com/gematik/spec-ISiK-Basismodul into feature/ISIK-Organization-PTData-521
@f-peverali
auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)
b7e7153
@f-peverali
add examples + other changes
19222fc
@f-peverali
auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)
ee474d9
@f-peverali
Merge branch 'rc/main-stufe-4' into feature/ISIK-Organization-PTData-521
9eb3efb
@MaxMTheilig
ospo readme
6849050
@MaxMTheilig
apache license details
d1e6efd
@MaxMTheilig
update for NoteJS 20
1c42d1d
@f-peverali
add Profile Fachabteilung
2dab6dd
@f-peverali
add Profiles Bett + Raum
08071ab
@MaxMTheilig
restructure IG
e5f57f4
@MaxMTheilig
auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)
bb1b2e6
@MaxMTheilig
progress on bessere IGs
b24e99d
@MaxMTheilig
auto-generated diagrams by GitHub Action after source code change
0d1b765
@MaxMTheilig
progress UC
605bb13
@MaxMTheilig
auto-generated diagrams by GitHub Action after source code change
edc89f7
@MaxMTheilig
zusammenfassung md
d5f02f9
@f-peverali
add puml
2ba6aca
@f-peverali
update relations
88bcda1
@f-peverali
update minor
f749a8d
f-peverali and others added 11 commits June 25, 2024 10:52
@f-peverali
update releasenotes
b649fac
@f-peverali
update to Benehmen Status
385f84a
@f-peverali
add VS for compatibility with Terminplanung - Stufe 4 (#418)
fd80ddf 
* add VS for compatibility with Terminplanung

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* Update Resources/input/fsh/ISiKOrganisation.fsh

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* fix VS

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* add slice einrichtungsart

* add alias FaclityType + fix practicecSetting + move fs-code

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* fix slice name

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* update releasenotes

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

---------

Co-authored-by: f-peverali <f-peverali@users.noreply.github.com>
@patrick-werner @f-peverali
Kommentare der KBV (#417)
cc6afa0 
* feat: sct.version  string has to be from the german sct edition

* Einpflegen der KBV Kommentare, Abgleich mit KBV, IPS

* Einpflegen der KBV Kommentare, Abgleich mit KBV, IPS, MII

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* update ReleaseNotes.md

* update ReleaseNotes.md

* update ReleaseNotes.md

* fix: removed wg14 coding profile

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* changes from PR review

* changes from PR review

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* fix: conditional MS Formulierung

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* Update Resources/input/fsh/ISiKDiagnose.fsh

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* Update Resources/input/fsh/ISiKDiagnose.fsh

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

---------

Co-authored-by: patrick-werner <patrick-werner@users.noreply.github.com>
Co-authored-by: f-peverali <112709306+f-peverali@users.noreply.github.com>
Co-authored-by: f-peverali <f-peverali@users.noreply.github.com>
@f-peverali
update version
654e9ec
@f-peverali
auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)
7fb267e
@f-peverali
fix typo an rm misleading paragraph
820c8f9
@f-peverali
improve typo
0ad69a2
@f-peverali
update bestätigungsrelevante systeme
ce92073
@f-peverali
improve typo
5baa402
@f-peverali
fix typo in example
6a1bb75
@f-peverali f-peverali marked this pull request as draft June 25, 2024 12:45
f-peverali
f-peverali commented Jun 25, 2024
View reviewed changes
ImplementationGuide/markdown/Versicherungsverhaeltnis/Versicherungsverhaeltnis_Interaktionen.md
@@ -14,13 +14,6 @@ Folgende Suchparameter sind für das Bestätigungsverfahren relevant, auch in Ko

Anwendungshinweise: Weitere Informationen zur Suche nach "_id" finden sich in der [FHIR-Basisspezifikation - Abschnitt "Parameters for all resources"](https://hl7.org/fhir/R4/search.html#all).

2. Der Suchparameter "identifier" zur Suche nach einer Krankenversicherten-ID MUSS unterstützt werden:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: ist das so beabsichtigt gewesen? @alexzautke @patrick-werner @simoneOnFhir ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, ist so richtig

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das kommt hier her: #362

@f-peverali f-peverali closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexzautke alexzautke alexzautke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@f-peverali @alexzautke @MaxMTheilig @lhitc @patrick-werner @jschoen-gefyra