feat: add ability to specify autoscreenshotSelector in story-files #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipayRT
approved these changes
Jun 7, 2024
KuznetsovRoman
commented
Jun 7, 2024
| @@ -7,6 +7,7 @@ export interface StorybookStoryExtended extends StorybookStory { | |||
| assertViewOpts: AssertViewOpts; | |||
| browserIds: Array<string | RegExp> | null; | |||
| extraTests?: Record<string, TestplaneTestFunction>; | |||
| autoscreenshotSelector: string | null; | |||
There was a problem hiding this comment.
Это - внутренний тип стори, расширенный дополнительными полями
| @@ -22,6 +22,7 @@ export type TestplaneMetaConfig<T = void> = Combined< | |||
| skip?: boolean; | |||
| assertViewOpts?: AssertViewOpts; | |||
| browserIds?: Array<string | RegExp>; | |||
| autoscreenshotSelector?: string; | |||
There was a problem hiding this comment.
Это - внешний тип, используемый пользователем.
| @@ -44,6 +44,7 @@ export function extendStoriesFromStoryFile(stories: StorybookStory[]): Storybook | |||
| story.skip = testplaneStoryOpts.skip || false; | |||
| story.assertViewOpts = testplaneStoryOpts.assertViewOpts || {}; | |||
| story.browserIds = testplaneStoryOpts.browserIds || null; | |||
| story.autoscreenshotSelector = testplaneStoryOpts.autoscreenshotSelector || null; | |||
There was a problem hiding this comment.
Прокидываем в сторю селектор, аналогично остальным опциям из default export
| @@ -24,7 +24,7 @@ function createTestplaneTests(story: StorybookStoryExtended, { autoScreenshots } | |||
|
|
|||
| const result = await openStoryStep(ctx.browser, story); | |||
|
|
|||
| await autoScreenshotStep(ctx.browser, result.rootSelector); | |||
| await autoScreenshotStep(ctx.browser, story.autoscreenshotSelector || result.rootSelector); | |||
There was a problem hiding this comment.
Если в сторе указан селектор (который прорастает туда из дефолтного экспорта), то он имеет приоритет над стандартным
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.