Add client function to return ping latency #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice idea. But I'd like a test. |
Added some tests, let me know if you'd like any changes :) |
gempir
reviewed
Sep 25, 2024
client_test.go
Outdated
| return diff | ||
| }() | ||
|
|
||
| if latencyDiff > time.Millisecond*3 { |
There was a problem hiding this comment.
This is so flakey... I don't like this at all.
There was a problem hiding this comment.
Yeah true but I don't see an alternative, I was getting 0ms locally and it worked consistently, but when actions runs the test it fails. Do you have a better idea?
There was a problem hiding this comment.
I could try reverting the last 2 commits and using returnedLatency.Truncate instead ofreturnedLatency.Round, but even if that works now I'm not sure it won't eventually cause your tests to fail because actions ran too slowly.
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought it would be useful to have a client function that returns ping latency like dank-twitch-irc does.