upgrade all ci to latest version

.github/workflows/build.yml

@@ -1,5 +1,5 @@
 name: Build
-on: [push, pull_request]
+on: [pull_request]
 jobs:
 
   build:
@@ -8,17 +8,17 @@ jobs:
 
     strategy:
       matrix:
-        go: [1.16, 1.17]
+        go: [stable, oldstable]
 
     steps:
       - name: Set up Go
-        uses: actions/setup-go@v1
+        uses: actions/setup-go@v5
         with:
           go-version: ${{ matrix.go }}
         id: go
 
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v1
+        uses: actions/checkout@v4
 
       - name: Get dependencies
         run: |

.github/workflows/goveralls.yml

@@ -1,5 +1,5 @@
 name: Goveralls
-on: [push, pull_request]
+on: [pull_request]
 jobs:
 
   goveralls:
@@ -8,15 +8,15 @@ jobs:
 
     strategy:
       matrix:
-        go: [1.16, 1.17]
+        go: [stable, oldstable]
 
     steps:
       - name: Set up Go
-        uses: actions/setup-go@v1
+        uses: actions/setup-go@v5
         with:
           go-version: ${{ matrix.go }}
 
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - run: go test -coverprofile=coverage.out
       - uses: shogo82148/actions-goveralls@v1
         with:

.github/workflows/lint.yml

@@ -1,18 +1,18 @@
 name: Go (Lint)
-on: [push, pull_request]
+on: [pull_request]
 jobs:
 
   golangci-lint:
     name: runner / golangci-lint (pre-build docker image)
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2.3.4
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v2.3.0
+        uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.42
+          version: v1.61
 
           args: --new-from-rev=e0a5614e47d349897~0

.golangci.yml

@@ -1,12 +1,8 @@
 linters-settings:
   govet:
     check-shadowing: true
-  golint:
-    min-confidence: 0
   gocyclo:
     min-complexity: 15
-  maligned:
-    suggest-new: true
   goconst:
     min-len: 2
     min-occurrences: 4
@@ -27,38 +23,26 @@ linters:
   disable-all: true
   enable:
     - bodyclose
-    - deadcode
-    - depguard
     - dogsled
-  # - dupl
     - errcheck
     - funlen
     - goconst
     - gocritic
     - gocyclo
     - gofmt
     - goimports
-    - golint
     - gosec
     - gosimple
     - govet
     - ineffassign
-    - interfacer
-  # - lll
-  # - misspell
-    - scopelint
     - staticcheck
-    - structcheck
     - stylecheck
     - typecheck
     - unconvert
     - unparam
-  # - unused
-    - varcheck
+    - unused
     - whitespace
     - gocognit
-  # - godox
-  # - maligned
     - prealloc
 
   # don't enable:

client.go

@@ -595,10 +595,10 @@ func (c *Client) Say(channel, text string) {
 }
 
 // Reply to a message previously sent in the same channel using the twitch reply feature
-func (c *Client) Reply(channel, parentMsgId string, text string) {
+func (c *Client) Reply(channel, parentMsgID, text string) {
 	channel = strings.ToLower(channel)
 
-	c.send(fmt.Sprintf("@reply-parent-msg-id=%s PRIVMSG #%s :%s", parentMsgId, channel, text))
+	c.send(fmt.Sprintf("@reply-parent-msg-id=%s PRIVMSG #%s :%s", parentMsgID, channel, text))
 }
 
 // Join enter a twitch channel to read more messages.