Rename 'socket' to 'smtp_socket' #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes compatibility with OTP-22 which introduces a socket module.
|
Looks good for me.
ср, 3 апр. 2019 г., 9:47 Marc Worrell <notifications@github.com>:
… This fixes compatibility with OTP-22 which introduces a socket module.
Fixes #168 <#168>
------------------------------
You can view, comment on, or merge this pull request online at:
#169
Commit Summary
- Rename 'socket' to 'smtp_socket'
File Changes
- *M* src/gen_smtp_client.erl
<https://github.com/Vagabond/gen_smtp/pull/169/files#diff-0> (498)
- *M* src/gen_smtp_server.erl
<https://github.com/Vagabond/gen_smtp/pull/169/files#diff-1> (14)
- *M* src/gen_smtp_server_session.erl
<https://github.com/Vagabond/gen_smtp/pull/169/files#diff-2> (1042)
- *R* src/smtp_socket.erl
<https://github.com/Vagabond/gen_smtp/pull/169/files#diff-3> (8)
Patch Links:
- https://github.com/Vagabond/gen_smtp/pull/169.patch
- https://github.com/Vagabond/gen_smtp/pull/169.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#169>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZwfn4xj6W_5dbISLYXLQseMxD-IJfCks5vdFyWgaJpZM4cZ1H_>
.
|
|
All tests pass as well. Waiting for a review ,though I think it is safe to merge. |
|
Looks alright to me |
|
Thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compatibility with OTP-22 which introduces a socket module.
Fixes #168