-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LOCO support for Plink format (Bimbam is in 0.97) #46
Comments
I am studying the GEMMA code to see how we add LOCO support. |
Okay @pjotrp. It basically would involve an "outer loop" that would run relationship matrix creation + LMM association analysis on each chromosome. Note that I have some R code (see function |
The outer loop may be the easiest hack for now though it will be hard to make generic for all supported input formats. If you look at the code you'll see that GEMMA has an innerloop for every file type it supports. I somehow need to plug in K-1 and subset SNPs. Looks like that will be pretty intrusive to make that generic. |
I have implemented LOCO for Bimbam format. I'll put in a PR after we agree on the coding style, see #62 |
Two more things need to be done:
I think we need to focus on BIMBAM and Plink formats for core algorithms. Other formats should really format into one of these and eventually we should remove internal support. That way we can become more DRY. wdyt? |
I agree. |
@pjotrp Sounds like a good plan to me! |
https://github.com/genetics-statistics/gemma-wrapper now runs all chromosomes and caches results too. Leaving issue open until I add LOCO to Plink. |
AnalyzeBimBam and AnalyzePlink contain duplicate logic - and they The functions can be split into:
The only thing specific regarding the input file format is (2). The |
Hello! Are there any news regarding LOCO for Plink format? |
It will happen sometime this year. If you want to help out :). Meanwhile, convert plink to BIMBAM. It can be done with the plink tool. |
It is part of gemma2/lib. Gemma2/lib converts plink and bimbam to a new Rqtl2/GEMMA2 format and that supports LOCO. |
We should add leave one chromosome out support to GEMMA. From what I can tell from the source code this is not particularly hard because GEMMA already tracks chromosome information. We need to recompute the kinship matrix for n chromosomes leaving one out and then rerun the LMM and run GEMMA n+1 times and present a result file with n+1 scores. I think this should be an internal feature of GEMMA and one would like to save the precomputed kinship matrices for rerunning with covariates etc.
The text was updated successfully, but these errors were encountered: