Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nf-core CI #31

Closed
wants to merge 0 commits into from
Closed

Add nf-core CI #31

wants to merge 0 commits into from

Conversation

samuell
Copy link
Contributor

@samuell samuell commented Nov 27, 2024

This PR adds GitHub Actions CI pipelines recommended and included in the nf-core template.

It also fixes some issues reported by an initial run with the nf-core lint tool.

  • Add missing TEMPLATE branch (see here)

@samuell samuell linked an issue Nov 27, 2024 that may be closed by this pull request
@samuell
Copy link
Contributor Author

samuell commented Nov 27, 2024

There are some syntax problems with some files, preventing the linting from completing:

prettier.................................................................Failed                                                                                                                             
         - hook id: prettier                                                                                                                                                                                         
         - exit code: 2                                                                                                                                                                                              
                                                                                                                                                                                                                     
         ../../../../../../tmp/tmpezw_7axu/genomic-medicine-sweden-GMS_16S/assets/email_template.html                                                                                                                
         ../../../../../../tmp/tmpezw_7axu/genomic-medicine-sweden-GMS_16S/.github/ISSUE_TEMPLATE/bug_report.yml                                                                                                     
         ../../../../../../tmp/tmpezw_7axu/genomic-medicine-sweden-GMS_16S/.nf-core.yml                                                                                                                              
                                                                                                                                                                                                                     
          ../../../../../../tmp/tmpezw_7axu/genomic-medicine-sweden-GMS_16S/assets/adaptivecard.json: SyntaxError: Unexpected token (57:47)                                                                          
            55 |                                 {                                                                                                                                                                   
            56 |                                     "type": "FactSet",                                                                                                                                              
          > 57 |                                     "facts": [<% out << summary.collect{ k,v -> "{\"title\": \"$k\", \"value\" : \"$v\"}"}.join(",\n") %>                                                           
               |                                               ^                                                                                                                                                     
            58 |                                     ]                                                                                                                                                               
            59 |                                 }                                                                                                                                                                   
            60 |                             ]                                                                                                                                                                       
         ../../../../../../tmp/tmpezw_7axu/genomic-medicine-sweden-GMS_16S/README.md                                                                                                                                 
                                                                                                                                                                                                                     
          ../../../../../../tmp/tmpezw_7axu/genomic-medicine-sweden-GMS_16S/assets/slackreport.json: SyntaxError: Unexpected token (15:18)                                                                           
            13 |                     "short": false                                                                                                                                                                  
            14 |                 }                                                                                                                                                                                   
          > 15 |                 <%                                                                                                                                                                                  
               |                  ^                                                                                                                                                                                  
            16 |                     if (!success) { %>                                                                                                                                                              
            17 |                     ,                                                                                                                                                                               
            18 |                     {       

@samuell
Copy link
Contributor Author

samuell commented Nov 27, 2024

As I think @sofstam mentioned, we should try to set up the process for syncing updates to the nf-core template, according to this guide. Seems to need some manual fixing to get it updated and "in sync".

@samuell samuell closed this Nov 28, 2024
@samuell samuell deleted the 30-add-nfcore-ci branch November 28, 2024 13:51
@samuell
Copy link
Contributor Author

samuell commented Nov 28, 2024

This draft PR was accidentally closed. Opening a new one ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include github actions to follow nf-core structure.
1 participant