Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in distfuse #1

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Fix in distfuse #1

merged 1 commit into from
Jun 18, 2024

Conversation

dokato
Copy link
Contributor

@dokato dokato commented Jun 18, 2024

Great idea for a library. I fixed minor typo below. Also suggestion that maybe better to import libraries when you recognise the type:

if type == "openai":
  from openai import OpenAI
elif type == "cohere":
  import cohere

otherwise you expect the user to have all APIs installed, even if they don't want to use them.

Copy link
Owner

@gentaiscool gentaiscool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for noticing!

@gentaiscool gentaiscool merged commit c5fd886 into gentaiscool:main Jun 18, 2024
@gentaiscool
Copy link
Owner

Thank you for the suggestion. I will consider to change the logic to import the library when needed.

@dokato dokato deleted the patch-1 branch June 18, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants